Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Dutch language #1310

Merged
merged 3 commits into from
Mar 30, 2024
Merged

Add Dutch language #1310

merged 3 commits into from
Mar 30, 2024

Conversation

devlanda
Copy link
Contributor

No description provided.

perry-mitchell
perry-mitchell requested changes Mar 29, 2024
View reviewed changes
Copy link
Member

@perry-mitchell perry-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but needs the @buttercup/ui package updated to 6.4.0 to include your other changes.

@devlanda
Copy link
Contributor Author

Thanks for your feedback @perry-mitchell.

Due to a typo, I've created another PR: buttercup/ui#75

Will try to update the @buttercup/ui package when it becomes available as a release (6.4.1?).

@perry-mitchell
Copy link
Member

perry-mitchell commented Mar 30, 2024 •
edited
Loading

6.4.2 released with the typo fixed @devlanda

I'll update this myself to save you the trouble :)

@perry-mitchell perry-mitchell merged commit 2fbb46b into buttercup:master Mar 30, 2024
@devlanda devlanda deleted the add-dutch-language branch March 30, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perry-mitchell perry-mitchell perry-mitchell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devlanda @perry-mitchell